refactor keybinding resolver #178699
Merged
refactor keybinding resolver #178699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make it easier to reason about keybinding resolution result
…ite more specification-like tests
ulugbekna
force-pushed
the
ulugbekna/refactor-kb-resolver
branch
from
f4e02c6
to
dcd0d14
Compare
This was referenced May 4, 2023
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Cleans up
KeybindingResolver&AbstractKeybindingServiceHow to review
Best reviewed commit by commit because some of commits are simply reordering code (for good reasons, IMHO)